20

Oct

2017

Mozilla Thimble: Issue 1918 Update (10.20.17) – Merged

Misc., Mozilla, Open Source, Thimble

fix, GitHub, issue, thimble

Mozilla Thimble – Issue# 1918

Date	Status
10/20/2017	since I made a mess of the commit history I read up on rebasing a branch onto master and squashing commits.I came across a great post from Digital Ocean: How To Rebase and Update a Pull Request The pull request was merged to Thimbles master branch!
10/13/2017	@gideonthomas suggested relocating the static string `publishHeaderOnline` to `server-client-shared.properties` since it will be used by both client and server. pushed new commits to be reviewed 2c50037
10/12/2017	Patch suddenly stopped working I started helping a @mpierre9 who was working on a similar issue 2355. After updating my forked master branch, I created a new test branch. In the process I managed to make a mess of my original pull request branch and merged the new changes from master. Commence panic! I switched back to the branch I submitted the pull request on to retest my original fix. I somehow created an issue from an issue. After testing multiple browsers and clearing the cache I came to the conclusion that my development environment somehow managed to cache the existing strings. Since the server side was displaying the new `PublishHeaderOnline` string it had no access to the `client.properties` string `publishHeader`
10/11/2017<	Marked for review and suggested edit to locales/en-US/server.properties
10/8/2017	Submitted Pull Request #2523 pending review
10/7/2017	id.webmaker 404 error was fixed. Login/publish services working properly Began working on fix
10/4/2017 – 10/5/2017	error when trying to launch id.webmaker services uninstall/reinstall VMBox, Vagrant (NO FIX) vagrant destroy + vagrant up (NO FIX) attempt separate build environment on a linux machine(NO-FIX)
9/30/2017	assigned to issue#1918 (Read More)